Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2837#discussion_r228715336
  
    --- Diff: store/CSDK/src/CarbonReader.h ---
    @@ -40,6 +40,19 @@ class CarbonReader {
          */
         jobject carbonReaderObject;
     
    +    /**
    +     * check whether has called builder
    --- End diff --
    
    can you improve this comment, suggest you write like "Return true if ...."


---

Reply via email to