GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2879
[CARBONDATA-3058] Fix some exception coding in data loading
1. when exception occur in `dataHandler.finish();`, carbon does not proceed
it immediately. Carbon keeps the exception and calls method to close the
datahandler. But the exception would be overwrite if another exception occur
when closing the dataHandler. This makes us lost the root cause.
Refer to `AbstractFactDataWriter.closeExecutorService()` and
`CarbonFactDataWriterImplV3.closeWriter()`, we add null check before the second
time assignment in `CarbonRowDataWriterProcessorStepImpl.finish()` and
`DataWriterBatchProcessorStepImpl` to avoid exception overwrite.
2. remove irrelevant exception message "unable to generate the mdkey", use
the exception itself directly. Message in the exception will be retrieved
automatically when logging.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinjmh/carbondata exceptionFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2879.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2879
----
commit a36f9c98338e1ae38a9c4d9afb4bcd5ab1eb9b23
Author: Manhua <kevinjmh@...>
Date: 2018-10-29T11:05:03Z
fix exception
----
---
