Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2879#discussion_r229280426
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterBatchProcessorStepImpl.java
 ---
    @@ -141,7 +141,9 @@ private void finish(String tableName, CarbonFactHandler 
dataHandler) {
         try {
           processingComplete(dataHandler);
         } catch (Exception e) {
    -      exception = new CarbonDataWriterException(e.getMessage(), e);
    +      if (null == exception) {
    --- End diff --
    
    no need to keep the exception here. you can do the statistics in finally 
code block


---

Reply via email to