[GitHub] carbondata pull request #2882: [CARBONDATA-3060]Improve the command for cli ...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2882#discussion_r229278322
  
    --- Diff: tools/cli/src/main/java/org/apache/carbondata/tool/DataFile.java 
---
    @@ -453,7 +455,16 @@ private double computePercentage(byte[] data, byte[] 
min, byte[] max, ColumnSche
             return dataValue.divide(factorValue).doubleValue();
           }
           double dataValue, minValue, factorValue;
    -      if (column.getDataType() == DataTypes.SHORT) {
    +      if (columnChunk.column.isDimensionColumn() && DataTypeUtil
    --- End diff --
    
     move `DataTypeUtil` to next column


---