Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2882#discussion_r229297954
--- Diff: tools/cli/src/main/java/org/apache/carbondata/tool/DataFile.java
---
@@ -443,7 +444,8 @@ void computePercentage(byte[] shardMin, byte[]
shardMax) {
* @return result
*/
private double computePercentage(byte[] data, byte[] min, byte[] max,
ColumnSchema column) {
- if (column.getDataType() == DataTypes.STRING) {
+ if (column.getDataType() == DataTypes.STRING || column.getDataType()
== DataTypes.BOOLEAN
+ || column.hasEncoding(Encoding.DICTIONARY)) {
--- End diff --
yes, but min max will be surrogate keys right, showing min and max as
dictionary value is not useful right
---
