[GitHub] carbondata pull request #2871: [CARBONDATA-3051] Fix bugs in unclosed stream...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2871#discussion_r229282082
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java 
---
    @@ -169,7 +170,7 @@ public CarbonReaderBuilder withHadoopConf(String key, 
String value) {
               reader.initialize(split, attempt);
               readers.add(reader);
             } catch (Exception e) {
    -          reader.close();
    +          CarbonUtil.closeStreams(readers.toArray(new RecordReader[0]));
    --- End diff --
    
    Why not loop and close each one in the `readers`?


---