Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2871#discussion_r229535208
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java 
---
    @@ -169,7 +170,7 @@ public CarbonReaderBuilder withHadoopConf(String key, 
String value) {
               reader.initialize(split, attempt);
               readers.add(reader);
             } catch (Exception e) {
    -          reader.close();
    +          CarbonUtil.closeStreams(readers.toArray(new RecordReader[0]));
    --- End diff --
    
    `CarbonUtil.closeStreams` will loop and close the readers. Calling this 
will save the loc (line of code)


---

Reply via email to