Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2877#discussion_r229579618
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/encoder/Encoding.java ---
@@ -57,10 +62,55 @@ public static Encoding valueOf(int ordinal) {
return ADAPTIVE_DELTA_INTEGRAL;
} else if (ordinal == RLE_INTEGRAL.ordinal()) {
return RLE_INTEGRAL;
+ } else if (ordinal == DIRECT_STRING.ordinal()) {
--- End diff --
DIRECT_STRING ordinal in thrift file is 10. In this enum it is 11. Does it
cause problem for old stores if any one uses this method to get encoding?
---
