Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2877#discussion_r229620608
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/encoder/Encoding.java ---
    @@ -57,10 +62,55 @@ public static Encoding valueOf(int ordinal) {
           return ADAPTIVE_DELTA_INTEGRAL;
         } else if (ordinal == RLE_INTEGRAL.ordinal()) {
           return RLE_INTEGRAL;
    +    } else if (ordinal == DIRECT_STRING.ordinal()) {
    --- End diff --
    
    There will not be any problem as this ordinal is not used during thrift 
writing or any file persistence


---

Reply via email to