[GitHub] carbondata pull request #2882: [CARBONDATA-3060]Improve the command for cli ...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2882#discussion_r229961679
  
    --- Diff: 
tools/cli/src/main/java/org/apache/carbondata/tool/DataSummary.java ---
    @@ -314,23 +312,26 @@ private void printColumnStats(String columnName) 
throws IOException, MemoryExcep
               minPercent = String.format("%.1f", 
blocklet.getColumnChunk().getMinPercentage() * 100);
               maxPercent = String.format("%.1f", 
blocklet.getColumnChunk().getMaxPercentage() * 100);
               DataFile.ColumnChunk columnChunk = blocklet.columnChunk;
    -          if (columnChunk.column.isDimensionColumn() && DataTypeUtil
    +          if (columnChunk.column.hasEncoding(Encoding.DICTIONARY) || 
blocklet
    +              .getColumnChunk().column.getColumnName().contains(".val") || 
blocklet
    --- End diff --
    
    please make correct line wrapping, move `blocklet` to next line


---