Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230258183
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPageValueConverter.java
---
@@ -37,5 +40,6 @@
double decodeDouble(long value);
double decodeDouble(float value);
double decodeDouble(double value);
- void decodeAndFillVector(ColumnPage columnPage, ColumnVectorInfo
vectorInfo);
+ void decodeAndFillVector(byte[] pageData, ColumnVectorInfo vectorInfo,
BitSet nullBits,
+ DataType pageDataType, int pageSize);
--- End diff --
From `ColumnPageDecoder` we directly calling for `decodeAndFillVector`. So
is this method `decodeAndFillVector` required to be defined again in the
interface `ColumnPageValueConverter.java`? I think there is no need to define
the method again instead we can directly fill the vector in the decoder method
call itself. Please check the feasibility of it
---
