Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230260860
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -224,135 +239,134 @@ public void decodeAndFillVector(ColumnPage
columnPage, ColumnVectorInfo vectorIn
}
}
- private void fillVector(ColumnPage columnPage, CarbonColumnVector
vector,
- DataType vectorDataType, DataType pageDataType, int pageSize,
ColumnVectorInfo vectorInfo) {
+ private void fillVector(byte[] pageData, CarbonColumnVector vector,
DataType vectorDataType,
+ DataType pageDataType, int pageSize, ColumnVectorInfo vectorInfo,
BitSet nullBits) {
+ int k = 0;
--- End diff --
Rename `k` to a meaningful name
---
