GitHub user Sssan520 opened a pull request:
https://github.com/apache/carbondata/pull/2907
[CARBONDATA-3031] refining usage of numberofcores in CarbonProperties
**1**. many places use the function 'getNumOfCores' of CarbonProperties
which returns **the loading cores.**
**2**. so if we still use the value in scene like 'query' or 'compaction' ,
it will be confused.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Sssan520/carbondata numcores
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2907.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2907
----
commit f8e7cdfecaed9079b8a90b2604a89ec9630a2d90
Author: Sssan520 <liangap2008@...>
Date: 2018-07-02T11:12:24Z
[CARBONDATA-3031] refining usage of numberofcores in CarbonProperties
----
---
