[GitHub] carbondata pull request #2907: [CARBONDATA-3031] refining usage of numberofc...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2907#discussion_r231777987
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -951,27 +951,46 @@ public void print() {
         return compactionSize;
       }
     
    -  /**
    -   * Number of cores should be used while loading data.
    -   *
    -   * @return
    -   */
    -  public int getNumberOfCores() {
    +  public int getNumberOfCores(String key) {
    --- End diff --
    
    I think this method can be private now


---