Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2929#discussion_r235261186
  
    --- Diff: store/CSDK/src/CarbonRow.cpp ---
    @@ -170,6 +170,9 @@ char *CarbonRow::getString(int ordinal) {
         args[0].l = carbonRow;
         args[1].i = ordinal;
         jobject data = jniEnv->CallStaticObjectMethodA(rowUtilClass, 
getStringId, args);
    +    if (jniEnv->ExceptionCheck()) {
    --- End diff --
    
    Exception check should be done for all other method calls also like 
getBoolean, getFloat,etc.
    
    ArrayIndexOutofBoundsException on wrong index & cast exceptions  on wrong 
method usage are possible 


---

Reply via email to