Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2929#discussion_r235266305
  
    --- Diff: store/CSDK/src/CarbonRow.cpp ---
    @@ -170,6 +170,9 @@ char *CarbonRow::getString(int ordinal) {
         args[0].l = carbonRow;
         args[1].i = ordinal;
         jobject data = jniEnv->CallStaticObjectMethodA(rowUtilClass, 
getStringId, args);
    +    if (jniEnv->ExceptionCheck()) {
    --- End diff --
    
    1. done, please check again.
    2.no need create new jvm, it can be used again after catch. In the test 
case, I use one jvm and try catch exception in the first test case:  
tryCarbonRowException. testCarbonProperties is running after try catch.
    
    ```
      tryCatchException(env);
            tryCarbonRowException(env, smallFilePath);
            testCarbonProperties(env);
            testWriteData(env, "./data", 1, argv);
    ```


---

Reply via email to