Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r242390063
  
    --- Diff: 
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
 ---
    @@ -43,28 +43,25 @@ object HiveExample {
     
         import org.apache.spark.sql.CarbonSession._
     
    -    val carbonSession = SparkSession
    -      .builder()
    -      .master("local")
    -      .appName("HiveExample")
    -      .config("carbonSession.sql.warehouse.dir", 
warehouse).enableHiveSupport()
    -      .getOrCreateCarbonSession(
    -        store, metaStore_Db)
    +    val carbonSession = SparkSession.builder()
    +      .master("local").appName("HiveExample")
    +      .enableHiveSupport()
    +      .config("spark.sql.warehouse.dir", warehouse)
    +      .getOrCreateCarbonSession(store, metaStore_Db)
     
         carbonSession.sql("""DROP TABLE IF EXISTS 
HIVE_CARBON_EXAMPLE""".stripMargin)
     
         carbonSession
           .sql(
    -        """CREATE TABLE HIVE_CARBON_EXAMPLE (ID int,NAME string,SALARY 
double) STORED BY
    -          |'CARBONDATA' """
    -          .stripMargin)
    +        "CREATE TABLE HIVE_CARBON_EXAMPLE (ID int,NAME string,SALARY 
double) " +
    +          "STORED BY 'CARBONDATA' ")
     
         carbonSession.sql(
           s"""
    -           LOAD DATA LOCAL INPATH 
'$rootPath/integration/hive/src/main/resources/data.csv' INTO
    -           TABLE
    -         HIVE_CARBON_EXAMPLE
    -           """)
    +               LOAD DATA LOCAL INPATH 
'$rootPath/integration/hive/src/main/resources/data.csv' INTO
    +               TABLE
    +             HIVE_CARBON_EXAMPLE
    --- End diff --
    
    please optimize it or revert it.


---

Reply via email to