Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242394285
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -31,7 +31,7 @@ object HiveExample {
def main(args: Array[String]) {
--- End diff --
Please optimize this example and RunHiveExampleTest
like:org.apache.carbondata.examplesCI.RunExamples.
We should add the example to CI, and add some assert for exception and
result. We should avoid that some developer/PR change code and lead to the
hiveExample error, the developer need fix it before their PR merged
---
