Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243150967
  
    --- Diff: 
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
 ---
    @@ -22,52 +22,49 @@ import java.sql.{DriverManager, ResultSet, Statement}
     import org.apache.spark.sql.SparkSession
    --- End diff --
    
    Please move this example to example folder, I suggest to put all example in 
one module, so instead of adding another example module for hive, I think it is 
better add it in existing example module and rename it to carbondata-example 
from carbondata-example-spark2


---

Reply via email to