Github user SteNicholas commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2969#discussion_r243259131
  
    --- Diff: 
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
 ---
    @@ -85,25 +82,35 @@ object HiveExample {
     
         logger.info(s"============HIVE CLI IS STARTED ON PORT $port 
==============")
     
    -    statement.execute("CREATE TABLE IF NOT EXISTS " + "HIVE_CARBON_EXAMPLE 
" +
    -                      " (ID int, NAME string,SALARY double)")
    -    statement
    -      .execute(
    -        "ALTER TABLE HIVE_CARBON_EXAMPLE SET FILEFORMAT INPUTFORMAT 
\"org.apache.carbondata." +
    -        "hive.MapredCarbonInputFormat\"OUTPUTFORMAT 
\"org.apache.carbondata.hive." +
    -        "MapredCarbonOutputFormat\"SERDE \"org.apache.carbondata.hive." +
    -        "CarbonHiveSerDe\" ")
    +    statement.execute(
    +      s"""
    +         | CREATE TABLE IF NOT EXISTS HIVE_CARBON_EXAMPLE
    +         | (ID int, NAME string,SALARY double)
    +         | ROW FORMAT SERDE 'org.apache.carbondata.hive.CarbonHiveSerDe'
    +         | WITH SERDEPROPERTIES 
('mapreduce.input.carboninputformat.databaseName'='default',
    +         | 
'mapreduce.input.carboninputformat.tableName'='HIVE_CARBON_EXAMPLE')
    +       """.stripMargin)
    +
    +    statement.execute(
    +      s"""
    +         | ALTER TABLE HIVE_CARBON_EXAMPLE
    +         | SET FILEFORMAT
    +         | INPUTFORMAT 
\"org.apache.carbondata.hive.MapredCarbonInputFormat\"
    --- End diff --
    
    @jackylk Yeah, I really agree with you.But this pull request #3004 doesn't 
work in HiveExample.


---

Reply via email to