Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3031#discussion_r244269580
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
---
@@ -140,6 +140,7 @@ public boolean isLocalDictGeneratedPage() {
} else {
actualDataColumnPage.putBytes(rowId, bytes);
}
+ pageSize = rowId + 1;
--- End diff --
```suggestion
if (pageSize <= rowId) {
pageSize = rowId + 1;
}
```
LocalDictColumnPage construct method has init pageSize in line 80, I think
it's better to compare rowId and pageSize
---
