Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3031#discussion_r244914880
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
 ---
    @@ -140,6 +140,7 @@ public boolean isLocalDictGeneratedPage() {
         } else {
           actualDataColumnPage.putBytes(rowId, bytes);
         }
    +    pageSize = rowId + 1;
    --- End diff --
    
    I think it's okay now ....for complex type children like array<string> it 
can have more than 32k elements so page size also need to be changes


---

Reply via email to