Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r244708339
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
@@ -205,8 +205,10 @@ public
AbstractFactDataWriter(CarbonFactDataHandlerModel model) {
if (model.getNumberOfCores() > 1) {
numberOfCores = model.getNumberOfCores() / 2;
}
- fallbackExecutorService =
Executors.newFixedThreadPool(numberOfCores, new CarbonThreadFactory(
- "FallbackPool:" + model.getTableName() + ", range: " +
model.getBucketId()));
+ fallbackExecutorService = model.getFallBackExecutorService() != null
?
+ model.getFallBackExecutorService() :
+ Executors.newFixedThreadPool(numberOfCores, new
CarbonThreadFactory(
--- End diff --
Better to use "public CarbonThreadFactory(String name, boolean withTime)",
so that diff threads have diff names
---
