Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r245510098
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -2076,4 +2076,15 @@ private CarbonCommonConstants() {
*/
public static final String
CARBON_QUERY_DATAMAP_BLOOM_CACHE_SIZE_DEFAULT_VAL = "512";
+ public static final String CARBON_LOCAL_DICTIONARY_MAX_THRESHOLD =
--- End diff --
I think we should optimize this variable name.
The first time I saw this I thought it was duplicated with another
threshold for local dictionary. One is number based, another is storage size
based. Please take care of the readability.
---
