Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244915526
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -291,9 +291,6 @@ void CarbonWriter::localDictionaryThreshold(int
localDictionaryThreshold) {
}
void CarbonWriter::enableLocalDictionary(bool enableLocalDictionary) {
- if (enableLocalDictionary == NULL) {
--- End diff --
@KanakaKumar : In CPP, boolean false value is same as NULL. Both are zero.
Hence when we pass false, it always throws exception due to this wrong code.
Hence he removed.
@xubo245 : This is just two removal, no need separate PR. you can do with
#3048
---
