Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3035#discussion_r244947464
  
    --- Diff: store/CSDK/test/main.cpp ---
    @@ -709,6 +709,7 @@ bool testWithTableProperty(JNIEnv *env, char *path, int 
argc, char **argv) {
             writer.outputPath(path);
             writer.withCsvInput(jsonSchema);
             writer.withTableProperty("sort_columns", "shortField");
    +        writer.enableLocalDictionary(false);
    --- End diff --
    
    add test code for it. In CPP, it will convert NULL to false when user 
invoke CarbonWriter::enableLocalDictionary.


---

Reply via email to