[GitHub] carbondata pull request #3048: [CARBONDATA-3224] Support SDK/CSDK validate t...

[xubo245]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3048#discussion_r245252822
  
    --- Diff: store/CSDK/test/main.cpp ---
    @@ -526,6 +526,71 @@ void testCarbonProperties(JNIEnv *env) {
         }
     }
     
    +bool testValidateBadRecordsActionWithImproperValue(JNIEnv *env, char 
*path) {
    --- End diff --
    
    SDK already test enableLocalDictionary with false before, but I  didn't 
test in in CSDK.
     it throw exception when tester test it. So we should check in CSDK too.


---