Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245328731
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -179,7 +182,8 @@ public CarbonWriterBuilder uniqueIdentifier(long
timestamp) {
*
* @return updated CarbonWriterBuilder
*/
- public CarbonWriterBuilder withLoadOptions(Map<String, String> options) {
+ public CarbonWriterBuilder withLoadOptions(Map<String, String> options)
--- End diff --
IllegalArgumentException is used already for some validations below.
Better not to change the signature of method for the existing method. It causes
compilation errors for existing user code.
---
