[GitHub] carbondata issue #3046: [WIP] Added check to start fallback based on size

[xuchuanyin]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/3046
  
    Hi @kunal642 ，in your PR, the threshold size for storage of the local 
dictionary is specified by system (maybe later can be specified by user). But 
it will come up with an obvious problem that how can the use know the exactly 
value.
    
    I've read about Parquet that it will compare the dictionary encoded size 
with the original encoded size, only if the dictionary encoded size is smaller, 
will Parquet use it, otherwise it will fall back.
    
    So can the current implementation suite this scenario well?



---