Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3048#discussion_r245532720
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java 
---
    @@ -179,7 +181,8 @@ public CarbonWriterBuilder uniqueIdentifier(long 
timestamp) {
        *
        * @return updated CarbonWriterBuilder
        */
    -  public CarbonWriterBuilder withLoadOptions(Map<String, String> options) {
    +  public CarbonWriterBuilder withLoadOptions(Map<String, String> options)
    +      throws IllegalArgumentException {
    --- End diff --
    
    IllegalArgumentException is a RuntimeException, In general RuntimExceptions 
are not listed in throws part of method. It will be added in the javadoc if 
method like @throws IllegalArgumentException  <in which condition the exception 
is raised>


---

Reply via email to