jackylk commented on a change in pull request #3535: [WIP] Refactory data
loading for partition table
URL: https://github.com/apache/carbondata/pull/3535#discussion_r361857123
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##########
@@ -1228,7 +1228,7 @@ public static void removeTempFolder(Map<String,
FolderDetails> locationMap, Stri
locationMap = new HashMap<>();
}
- SegmentFile merge(SegmentFile mapper) {
+ public SegmentFile merge(SegmentFile mapper) {
Review comment:
name `mapper` is not good, can you rename it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
