jackylk commented on a change in pull request #3535: [WIP] Refactory data
loading for partition table
URL: https://github.com/apache/carbondata/pull/3535#discussion_r361857468
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
##########
@@ -481,10 +485,42 @@ public void close(TaskAttemptContext taskAttemptContext)
throws InterruptedExcep
// clean up the folders and files created locally for data load
operation
TableProcessingOperations.deleteLocalDataLoadFolderLocation(loadModel, false,
false);
}
+ OutputFilesInfoHolder outputFilesInfoHolder =
loadModel.getOutputFilesInfoHolder();
+ if (null != outputFilesInfoHolder) {
+ //TODO: fix to sum
Review comment:
Is this TODO required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
