jackylk commented on a change in pull request #3557: [CARBONDATA-3649] Hive expression is pushed down to carbon URL: https://github.com/apache/carbondata/pull/3557#discussion_r363070934
########## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/util/Hive2CarbonExpression.java ########## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.hadoop.util; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.carbondata.common.logging.LogServiceFactory; +import org.apache.carbondata.core.metadata.datatype.DataType; +import org.apache.carbondata.core.metadata.datatype.DataTypes; +import org.apache.carbondata.core.scan.expression.ColumnExpression; +import org.apache.carbondata.core.scan.expression.Expression; +import org.apache.carbondata.core.scan.expression.LiteralExpression; +import org.apache.carbondata.core.scan.expression.conditional.EqualToExpression; +import org.apache.carbondata.core.scan.expression.conditional.GreaterThanEqualToExpression; +import org.apache.carbondata.core.scan.expression.conditional.GreaterThanExpression; +import org.apache.carbondata.core.scan.expression.conditional.InExpression; +import org.apache.carbondata.core.scan.expression.conditional.LessThanEqualToExpression; +import org.apache.carbondata.core.scan.expression.conditional.LessThanExpression; +import org.apache.carbondata.core.scan.expression.conditional.ListExpression; +import org.apache.carbondata.core.scan.expression.conditional.NotEqualsExpression; +import org.apache.carbondata.core.scan.expression.logical.AndExpression; +import org.apache.carbondata.core.scan.expression.logical.OrExpression; +import org.apache.carbondata.hadoop.api.CarbonInputFormat; + +import org.apache.hadoop.hive.ql.plan.ExprNodeDesc; +import org.apache.hadoop.hive.ql.plan.ExprNodeFieldDesc; +import org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDF; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFIn; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPAnd; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPEqual; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPEqualOrGreaterThan; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPEqualOrLessThan; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPGreaterThan; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPLessThan; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPNotEqual; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPNotNull; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPNull; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDFOPOr; +import org.apache.log4j.Logger; + +/** + * @description: hive expression to carbon expression + */ +public class Hive2CarbonExpression { + public static final int left = 0; + public static final int right = 1; + private static final Logger LOG = + LogServiceFactory.getLogService(CarbonInputFormat.class.getName()); + + public static Expression convertExprHive2Carbon(ExprNodeDesc exprNodeDesc) { + if (exprNodeDesc instanceof ExprNodeGenericFuncDesc) { + ExprNodeGenericFuncDesc exprNodeGenericFuncDesc = (ExprNodeGenericFuncDesc) exprNodeDesc; + GenericUDF udf = exprNodeGenericFuncDesc.getGenericUDF(); + List<ExprNodeDesc> ll = exprNodeGenericFuncDesc.getChildren(); + if (udf instanceof GenericUDFIn) { + ColumnExpression columnExpression = new ColumnExpression(ll.get(left).getCols().get(left), + getDateType(ll.get(left).getTypeString())); + List<Expression> listExpr = new ArrayList<>(); + for (int i = right; i < ll.size(); i++) { + LiteralExpression literalExpression = new LiteralExpression(ll.get(i).getExprString(), + getDateType(ll.get(left).getTypeString())); + listExpr.add(literalExpression); + } + ListExpression listExpression = new ListExpression(listExpr); + return new InExpression(columnExpression, listExpression); + } else if (udf instanceof GenericUDFOPOr) { + Expression leftExpression = + convertExprHive2Carbon(exprNodeGenericFuncDesc.getChildren().get(left)); + Expression rightExpression = + convertExprHive2Carbon(exprNodeGenericFuncDesc.getChildren().get(right)); + return new OrExpression(leftExpression, rightExpression); + } else if (udf instanceof GenericUDFOPAnd) { + Expression leftExpression = + convertExprHive2Carbon(exprNodeGenericFuncDesc.getChildren().get(left)); + Expression rightExpression = + convertExprHive2Carbon(exprNodeGenericFuncDesc.getChildren().get(right)); + return new AndExpression(leftExpression, rightExpression); + + } else if (udf instanceof GenericUDFOPEqual) { + ColumnExpression columnExpression = null; + if (ll.get(left) instanceof ExprNodeFieldDesc) { + LOG.debug("Complex types are not supported"); Review comment: Better to throw exception to indicate it is not supported ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
