xiaohui0318 commented on a change in pull request #3557: [CARBONDATA-3649] Hive 
expression is pushed down to carbon
URL: https://github.com/apache/carbondata/pull/3557#discussion_r363280770
 
 

 ##########
 File path: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java
 ##########
 @@ -455,7 +459,26 @@ protected DataMapFilter getFilterPredicates(Configuration 
configuration) {
     try {
       String filterExprString = configuration.get(FILTER_PREDICATE);
       if (filterExprString == null) {
-        return null;
+        String expr = configuration.get(TableScanDesc.FILTER_EXPR_CONF_STR);
+        if (expr == null) {
+          return null;
+        }
+        ExprNodeGenericFuncDesc exprNodeGenericFuncDesc =
+            Utilities.deserializeObject(expr, ExprNodeGenericFuncDesc.class);
+        LOG.debug("hive expression:" + 
exprNodeGenericFuncDesc.getGenericUDF());
+        LOG.debug("hive expression string:" + 
exprNodeGenericFuncDesc.getExprString());
+        Expression expression =
+            
Hive2CarbonExpression.convertExprHive2Carbon(exprNodeGenericFuncDesc);
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to