ajantha-bhat commented on a change in pull request #3595: [CARBONDATA-3674]
remove Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage
URL: https://github.com/apache/carbondata/pull/3595#discussion_r372825333
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
##########
@@ -363,14 +363,14 @@ private void
fillDimensionsAndMeasuresForTables(TableSchema tableSchema) {
if (!columnSchema.isInvisible() && columnSchema.isSortColumn()) {
this.numberOfSortColumns++;
}
- if (!columnSchema.getEncodingList().contains(Encoding.DICTIONARY)) {
+ if (columnSchema.getDataType() != DataTypes.DATE) {
Review comment:
I think all the places we can remove below code also.
encodings.add(Encoding.DIRECT_DICTIONARY);
encodings.add(Encoding.DICTIONARY);
Also can remove the carbonColumn.hasEncoding(Encoding.DIRECT_DICTIONARY)
check from all the places.
so, can lookup the usages of Encoding.DIRECT_DICTIONARY, we can remove
everywhere other than thrift to maintain the compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
