jackylk commented on a change in pull request #3595: [CARBONDATA-3674] remove
Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage
URL: https://github.com/apache/carbondata/pull/3595#discussion_r372836145
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
##########
@@ -363,14 +363,14 @@ private void
fillDimensionsAndMeasuresForTables(TableSchema tableSchema) {
if (!columnSchema.isInvisible() && columnSchema.isSortColumn()) {
this.numberOfSortColumns++;
}
- if (!columnSchema.getEncodingList().contains(Encoding.DICTIONARY)) {
+ if (columnSchema.getDataType() != DataTypes.DATE) {
Review comment:
Following need to be removed later in another PR
encodings.add(Encoding.DIRECT_DICTIONARY);
encodings.add(Encoding.DICTIONARY);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
