xubo245 commented on a change in pull request #3595: [CARBONDATA-3674] remove
Encoding.DICTIONARY and Encoding.DIRECT_DICTIONARY usage
URL: https://github.com/apache/carbondata/pull/3595#discussion_r373480977
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/RestructureBasedRawResultCollector.java
##########
@@ -88,7 +88,7 @@ private void initRestructuredKeyGenerator() {
// partitioner index will be 1 every column will be in columnar
format
updatedDimensionPartitioner.add(1);
// for direct dictionary 4 bytes need to be allocated else 1
- if
(queryDimensions[i].getDimension().hasEncoding(Encoding.DIRECT_DICTIONARY)) {
+ if (queryDimensions[i].getDimension().getDataType() ==
DataTypes.DATE) {
Review comment:
it will be alway true because it the same with line 76, it should be
optimized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
