jackylk commented on a change in pull request #3538: [CARBONDATA-3637] Optimize
insert into flow
URL: https://github.com/apache/carbondata/pull/3538#discussion_r376196174
##########
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala
##########
@@ -316,16 +315,15 @@ private[sql] case class CarbonProjectForUpdateCommand(
val header = getHeader(carbonRelation, plan)
- CarbonLoadDataCommand(
+ CarbonInsertIntoWithDf(
Some(carbonRelation.identifier.getCarbonTableIdentifier.getDatabaseName),
carbonRelation.identifier.getCarbonTableIdentifier.getTableName,
- null,
- Seq(),
Map(("fileheader" -> header)),
false,
null,
- Some(dataFrame),
- Some(updateTableModel)).run(sparkSession)
+ dataFrame,
Review comment:
please add parameter names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
