ajantha-bhat commented on a change in pull request #3538: [CARBONDATA-3637]
Optimize insert into flow
URL: https://github.com/apache/carbondata/pull/3538#discussion_r376334978
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepWithNoConverterImpl.java
##########
@@ -334,6 +356,42 @@ private CarbonRowBatch getBatch() {
return newData;
}
+ private Object[] convertToNoDictionaryToBytesWithoutReArrange(Object[]
data,
Review comment:
I checked , This is different. In original method when ordered data is
present it is based on no dictionary mapping, I don't want to use no dictionary
mapping.
complex type logic is same, may be I will extract a common method for that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
