akashrn5 commented on a change in pull request #3625: [CARBONDATA-3705] Support
create and load MV for spark datasource table
URL: https://github.com/apache/carbondata/pull/3625#discussion_r383437391
##########
File path:
mv/core/src/main/scala/org/apache/carbondata/mv/extension/MVHelper.scala
##########
@@ -610,13 +616,12 @@ object MVHelper {
val relationList = fields._2.columnTableRelationList
// check if columns present in datamap are long_string_col in parent
table. If they are
// long_string_columns in parent, make them long_string_columns in
datamap
- if (aggFunc.isEmpty &&
- relationList.size == 1 &&
-
longStringColumnInParents.contains(relationList.head.parentColumnName)) {
- varcharDatamapFields += relationList.head.parentColumnName
+ if (aggFunc.isEmpty && relationList.size == 1 &&
longStringColumnInParents
+ .contains(relationList.head.columnName)) {
+ varcharDatamapFields += relationList.head.columnName
}
})
- if (varcharDatamapFields.nonEmpty) {
+ if (!varcharDatamapFields.isEmpty) {
Review comment:
revert this change, old one was correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
