jackylk commented on a change in pull request #3625: [CARBONDATA-3705] Support
create and load MV for spark datasource table
URL: https://github.com/apache/carbondata/pull/3625#discussion_r383697114
##########
File path:
mv/core/src/main/scala/org/apache/carbondata/mv/extension/MVHelper.scala
##########
@@ -72,42 +69,41 @@ object MVHelper {
dataMapSchema: DataMapSchema,
queryString: String,
ifNotExistsSet: Boolean = false): Unit = {
- val dmProperties = dataMapSchema.getProperties.asScala
- if (dmProperties.contains("streaming") &&
dmProperties("streaming").equalsIgnoreCase("true")) {
+ val properties = dataMapSchema.getProperties.asScala
+ if (properties.contains("streaming") &&
properties("streaming").equalsIgnoreCase("true")) {
throw new MalformedCarbonCommandException(
s"Materialized view does not support streaming"
)
}
val mvUtil = new MVUtil
- mvUtil.validateDMProperty(dmProperties)
- val logicalPlan = dropDummyFunc(
- MVParser.getMVPlan(queryString, sparkSession))
+ mvUtil.validateDMProperty(properties)
+ val queryPlan = dropDummyFunc(MVParser.getMVPlan(queryString,
sparkSession))
// if there is limit in MV ctas query string, throw exception, as its not
a valid usecase
- logicalPlan match {
+ queryPlan match {
case Limit(_, _) =>
throw new MalformedCarbonCommandException("Materialized view does not
support the query " +
"with limit")
case _ =>
}
- val selectTables = getTables(logicalPlan)
- if (selectTables.isEmpty) {
+ val mainTables = getCatalogTables(queryPlan)
+ if (mainTables.isEmpty) {
throw new MalformedCarbonCommandException(
s"Non-Carbon table does not support creating MV datamap")
}
- val modularPlan = validateMVQuery(sparkSession, logicalPlan)
+ val modularPlan = validateMVQuery(sparkSession, queryPlan)
val updatedQueryWithDb = modularPlan.asCompactSQL
- val (timeSeriesColumn, granularity): (String, String) =
validateMVTimeSeriesQuery(
- logicalPlan,
- dataMapSchema)
- val fullRebuild = isFullReload(logicalPlan)
+ val (timeSeriesColumn, granularity) = validateMVTimeSeriesQuery(queryPlan,
dataMapSchema)
+ val isQueryNeedFullRebuild = checkIsQueryNeedFullRebuild(queryPlan)
+ val isHasNonCarbonProvider = checkIsMainTableHasNonCarbonSource(mainTables)
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
