akashrn5 commented on a change in pull request #3614: [CARBONDATA-3693]
Separate Index command from DataMap command
URL: https://github.com/apache/carbondata/pull/3614#discussion_r384035745
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
##########
@@ -168,6 +186,38 @@ public DataMapSchema getDataMapSchema(String dataMapName)
return provider.retrieveSchema(dataMapName);
}
+ public List<DataMapSchema> getAllMVSchemas() throws IOException {
+ return provider.retrieveAllSchemas().stream()
+ .filter(schema -> !schema.isIndexDataMap())
+ .collect(Collectors.toList());
+ }
+
+ public DataMapSchema getIndexSchema(String indexName)
+ throws NoSuchIndexException, IOException {
+ try {
+ DataMapSchema schema = provider.retrieveSchema(indexName);
+ if (!schema.isIndexDataMap()) {
+ throw new NoSuchIndexException(indexName);
+ }
+ return schema;
+ } catch (NoSuchDataMapException e) {
Review comment:
please add `LOGGER.error()` here and if no schema file is present, it will
throw IO exception, if while reading schema failed IOexception is thrown,
always saying NoSuchIndexException is misleading i think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
