akashrn5 commented on a change in pull request #3614: [CARBONDATA-3693]
Separate Index command from DataMap command
URL: https://github.com/apache/carbondata/pull/3614#discussion_r384033877
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapProvider.java
##########
@@ -48,25 +49,26 @@
import org.apache.log4j.Logger;
/**
- * DataMap is a accelerator for certain type of query. Developer can add new
DataMap
+ * Index is a accelerator for certain type of query. Developer can add new
Index
* implementation to improve query performance.
*
- * Currently two types of DataMap are supported
+ * Currently two types of Index are supported
* <ol>
- * <li> MVDataMap: materialized view type of DataMap to accelerate olap
style query,
+ * <li> MVDataMap: materialized view type of Index to accelerate olap style
query,
* like SPJG query (select, predicate, join, groupby) </li>
- * <li> DataMap: index type of DataMap to accelerate filter query </li>
+ * <li> Index: index type of Index to accelerate filter query </li>
* </ol>
*
* <p>
* In following command <br>
- * {@code CREATE DATAMAP dm ON TABLE main USING 'provider'}, <br>
- * the <b>provider</b> string can be a short name or class name of the DataMap
implementation.
+ * {@code CREATE INDEX index ON main AS 'provider'}, <br>
Review comment:
`on table ` should not be removed here, its required
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
