jackylk commented on a change in pull request #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#discussion_r386006342
########## File path: core/src/main/java/org/apache/carbondata/core/mutate/data/BlockMappingVO.java ########## @@ -30,6 +30,8 @@ private Map<String, RowCountDetailsVO> completeBlockRowDetailVO; + private Map<String, String> blockToSegmentMapping; Review comment: There are too many mappings in this class, can you avoid it. Its meaning is not easy to understand ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
