akashrn5 commented on a change in pull request #3639: [CARBONDATA-3724]
Secondary Index enable on partition Table
URL: https://github.com/apache/carbondata/pull/3639#discussion_r386084021
##########
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##########
@@ -2756,11 +2756,29 @@ private static long getMaxOfBlockAndFileSize(long
blockSize, long fileSize) {
* @param identifier
* @param filePath
* @param segmentId
+ * @param isTransactionalTable
* @param isStandardTable
* @return
*/
public static String getBlockId(AbsoluteTableIdentifier identifier, String
filePath,
String segmentId, boolean isTransactionalTable, boolean isStandardTable)
{
+ return getBlockId(identifier, filePath, segmentId, isTransactionalTable,
isStandardTable,
+ false);
+ }
+
+ /**
+ * Generate the blockid as per the block path
+ *
+ * @param identifier
Review comment:
remove @param from comment, i not explained and straight forward
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
