ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731]
Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#discussion_r387465206
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/compression/Compressor.java
##########
@@ -18,36 +18,39 @@
package org.apache.carbondata.core.datastore.compression;
import java.io.IOException;
+import java.nio.ByteBuffer;
public interface Compressor {
String getName();
- byte[] compressByte(byte[] unCompInput);
+ ByteBuffer compressByte(ByteBuffer compInput);
Review comment:
Similar problem exists in query flow also ? can we use `ByteBuffer` for
`uncompress` return type also ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
