ajantha-bhat commented on a change in pull request #3638: [CARBONDATA-3731]
Avoid data copy in Writer
URL: https://github.com/apache/carbondata/pull/3638#discussion_r387467961
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
##########
@@ -218,10 +224,11 @@ public static ColumnPage newPage(ColumnPageEncoderMeta
columnPageEncoderMeta, in
instance = newDoublePage(columnPageEncoderMeta, new double[pageSize]);
} else if (DataTypes.isDecimal(dataType)) {
instance = newDecimalPage(columnPageEncoderMeta, new byte[pageSize][]);
- } else if (dataType == DataTypes.STRING
- || dataType == BYTE_ARRAY
- || dataType == DataTypes.VARCHAR
- || dataType == DataTypes.BINARY) {
+ } else if (dataType == DataTypes.STRING ||
+ dataType == DataTypes.VARCHAR ||
+ dataType == DataTypes.BINARY) {
+ instance = new ByteBufferColumnPage(columnPageEncoderMeta, pageSize);
+ } else if (dataType == BYTE_ARRAY) {
Review comment:
same as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
