ajantha-bhat commented on a change in pull request #3584: [CARBONDATA-3718]
Support SegmentLevel MinMax for better Pruning and less driver memory usage for
cache
URL: https://github.com/apache/carbondata/pull/3584#discussion_r389640631
##########
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
##########
@@ -390,9 +399,9 @@ object CarbonDataRDDFactory {
carbonLoadModel,
hadoopConf)
} else if (dataFrame.isDefined) {
- loadDataFrame(sqlContext, dataFrame, None, carbonLoadModel)
+ loadDataFrame(sqlContext, dataFrame, None, carbonLoadModel,
segmentMinMaxAccumulator)
Review comment:
For compaction, we are recalculating the min max again by reading each block
file?
we can just find the min and max from the segments involved in the
compaction. No need to compute segment min may by reading each data file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
