ajantha-bhat commented on a change in pull request #3584: [CARBONDATA-3718]
Support SegmentLevel MinMax for better Pruning and less driver memory usage for
cache
URL: https://github.com/apache/carbondata/pull/3584#discussion_r389603171
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java
##########
@@ -135,7 +135,7 @@ public CarbonTable getTable() {
int datamapsCount = 0;
// In case if filter has matched partitions, then update the segments with
datamap's
// segment list, as getDataMaps will return segments that matches the
partition.
- if (null != partitions && !partitions.isEmpty()) {
+ if (null != partitions && !partitions.isEmpty() || (null != filter &&
!filter.isEmpty())) {
Review comment:
Suppose to be && instead of || ?
line 123:
boolean usePartitionInfoForDataMapPruning = table.isHivePartitionTable() &&
filter != null && !filter.isEmpty() && partitions != null
and use the same flag to reset in line 138, it is confusing now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
