ajantha-bhat commented on a change in pull request #3653: [CARBONDATA-3665]
Support TimeBased Cache expiration using ExpiringMap
URL: https://github.com/apache/carbondata/pull/3653#discussion_r390866216
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
##########
@@ -146,8 +146,15 @@ public BlockletDataMapIndexWrapper
get(TableBlockIndexUniqueIdentifierWrapper id
new BlockletDataMapIndexWrapper(identifier.getSegmentId(),
dataMaps);
}
if (identifierWrapper.isAddTableBlockToUnsafeAndLRUCache()) {
+ String cacheExpirationTime =
+
identifierWrapper.getCarbonTable().getTableInfo().getFactTable().getTableProperties()
Review comment:
move to method and reuse everywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
